diff --git a/packages/react-core/CONTRIBUTING.md b/packages/react-core/CONTRIBUTING.md index 8ce6f8e1bc3..ef8f625f0e7 100644 --- a/packages/react-core/CONTRIBUTING.md +++ b/packages/react-core/CONTRIBUTING.md @@ -79,17 +79,15 @@ $ yarn test Ensure no lint errors are introduced in `yarn-error.log` after running this command. -5. Add a commit using `yarn commit`: +5. Add a commit using `git commit`: -This project uses [`lerna`](https://lernajs.io/) to do automatic releases and generate a changelog based on the commit history. So we follow [a convention][3] for commit messages. Please follow this convention for your commit messages. - -You can use `commitizen` to help you to follow [the convention][3]. +This project uses [`lerna`](https://lerna.js.io/) to do automatic releases and generate a changelog based on the commit history. So we follow [a convention][3] for commit messages. Please follow [`this convention`](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#type) for your commit messages. Once you are ready to commit the changes, please use the below commands: ```text $ git add -$ yarn commit +$ git commit -m ``` ... and follow the instruction of the interactive prompt. diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 034ca70bd64..8ebd348bf03 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -118,6 +118,8 @@ export interface SearchInputProps extends Omit, /** The number of search results returned. Either a total number of results, * or a string representing the current result over the total number of results. i.e. "1 / 5". */ resultsCount?: number | string; + /** Screenreader text that will appear after resultsCount to give context for what that value represents to assistive technologies. */ + resultsCountContext?: string; /** Label for the button which calls the onSearch event handler. */ submitSearchButtonLabel?: string; /** Value of the search input. */ @@ -144,6 +146,7 @@ const SearchInputBase: React.FunctionComponent = ({ onToggleAdvancedSearch, isAdvancedSearchOpen = false, resultsCount, + resultsCountContext = ' results', onNextClick, onPreviousClick, innerRef, @@ -309,7 +312,11 @@ const SearchInputBase: React.FunctionComponent = ({ /> {(renderUtilities || areUtilitiesDisplayed) && ( - {resultsCount && {resultsCount}} + {resultsCount && ( + + {resultsCount} + + )} {!!onNextClick && !!onPreviousClick && (