Skip to content

Fix updating lockfile in dependabot PRs #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fhlavac opened this issue Jan 29, 2025 · 0 comments
Open

Fix updating lockfile in dependabot PRs #283

fhlavac opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@fhlavac
Copy link
Collaborator

fhlavac commented Jan 29, 2025

Currently, there is an issue in PRs opened by dependabot

  • when a dependency is updated in package.json, the change is not reflected in the package-lock.json - merging such PRs may be dangerous as the CI is not actually running with the updated version of the dependency
  • PRs updating only dependencies listed in the package-lock.json file look correct

clone of #patternfly/react-component-groups#557
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 29, 2025
@fhlavac fhlavac mentioned this issue Jan 29, 2025
Open
@fhlavac fhlavac added the bug Something isn't working label Jan 29, 2025
@dlabaj dlabaj self-assigned this Feb 11, 2025
@dlabaj dlabaj moved this from Needs triage to Ready to assign in PatternFly Issues Feb 11, 2025
@dlabaj dlabaj removed their assignment Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
PatternFly Issues
Status: Ready to assign
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlabaj @fhlavac