-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add restart pruning to OM3 driver #562
Conversation
Sorry yet another review :-) @dougiesquire and @jo-basevi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! Just one comment really on the return type when there's an unsupported calendar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anton-seaice - it looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @anton-seaice! I only flagged the additional space below to prove I did look at this 🙂
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
2c56dc9
Thanks all - there's no more changes, but this needs approving again :-) |
Closes #506
This adds support for date based restart pruning to the access-om3 driver.
This uses the payu framework for restart pruning, the only addition is a
get_restart_datetime()
function with the a access-om3 class.