Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart pruning to OM3 driver #562

Merged
merged 11 commits into from
Feb 13, 2025
Merged

Conversation

anton-seaice
Copy link
Contributor

Closes #506

This adds support for date based restart pruning to the access-om3 driver.

This uses the payu framework for restart pruning, the only addition is a get_restart_datetime()
function with the a access-om3 class.

@anton-seaice
Copy link
Contributor Author

Sorry yet another review :-) @dougiesquire and @jo-basevi

@coveralls
Copy link

coveralls commented Feb 10, 2025

Coverage Status

coverage: 59.546%. first build
when pulling 2c56dc9 on 506-om3-restart-pruning
into 2241178 on master.

jo-basevi
jo-basevi previously approved these changes Feb 11, 2025
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Just one comment really on the return type when there's an unsupported calendar

jo-basevi
jo-basevi previously approved these changes Feb 12, 2025
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice - it looks good to me

dougiesquire
dougiesquire previously approved these changes Feb 13, 2025
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @anton-seaice! I only flagged the additional space below to prove I did look at this 🙂

Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
@anton-seaice anton-seaice dismissed stale reviews from dougiesquire and jo-basevi via 2c56dc9 February 13, 2025 21:06
@anton-seaice
Copy link
Contributor Author

Thanks all - there's no more changes, but this needs approving again :-)

@anton-seaice anton-seaice merged commit d0fdbff into master Feb 13, 2025
7 checks passed
@anton-seaice anton-seaice deleted the 506-om3-restart-pruning branch February 13, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for date-based restart pruning in OM3
5 participants