-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit MOM_parameter_doc.* into docs folder of config #567
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look great @anton-seaice. I've one question for now and a few suggestions to take or leave.
I haven't actually tested this yet, but will now.
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
(Sorry, wrote this comment and forgot to click "Comment") I tested configurations for:
So it's committing when it shouldn't but otherwise working as expected. |
I think i fixed this. I changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the AccessOm3
driver again and now works as expected. Maybe worth waiting for approval from a real Payu developer before merging though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me - thanks @anton-seaice!
Its me again ... needing something approved again :-) |
This is ready to go (again!) @dougiesquire |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anton-seaice. Looks good to me and tested successfully
Closes #565
When using the access-om3 driver, the commits the MOM output documentation (
MOM_parameter_doc.*
) into thedocs
folder of the config being run.If
runlog: False
it adds the docs folder it without committingIf
runlog: True
it commits it, with the message "payu archive: documentation of MOM6 run-time configuration"@dougiesquire - do you have a MOM6 standalone config i can test this with ?
@chrisb13 - if you'd like, we could try and do an "online/in zoom" review for training purposes. We probably need @jo-basevi because i'm a hack