Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit MOM_parameter_doc.* into docs folder of config #567

Merged
merged 16 commits into from
Feb 20, 2025

Conversation

anton-seaice
Copy link
Contributor

Closes #565

When using the access-om3 driver, the commits the MOM output documentation (MOM_parameter_doc.*) into the docs folder of the config being run.

If runlog: False it adds the docs folder it without committing

If runlog: True it commits it, with the message "payu archive: documentation of MOM6 run-time configuration"

@dougiesquire - do you have a MOM6 standalone config i can test this with ?

@chrisb13 - if you'd like, we could try and do an "online/in zoom" review for training purposes. We probably need @jo-basevi because i'm a hack

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great @anton-seaice. I've one question for now and a few suggestions to take or leave.

I haven't actually tested this yet, but will now.

anton-seaice and others added 3 commits February 14, 2025 10:27
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
Co-authored-by: Dougie Squire <42455466+dougiesquire@users.noreply.github.com>
@dougiesquire
Copy link
Collaborator

(Sorry, wrote this comment and forgot to click "Comment")

I tested configurations for:

  • AccessOm3 driver
    • runlog: False : commits docs
    • runlog: True : works as expected
  • Mom6 driver
    • runlog: False : again, commits docs
    • runlog: True : works as expected

So it's committing when it shouldn't but otherwise working as expected.

@coveralls
Copy link

coveralls commented Feb 14, 2025

Coverage Status

coverage: 58.441% (-0.9%) from 59.366%
when pulling 305dbd7 on 565-commit-momdocs
into d0fdbff on master.

@anton-seaice
Copy link
Contributor Author

So it's committing when it shouldn't but otherwise working as expected.

I think i fixed this.

I changed model.config to model.expt.config, I think thats correct :)

dougiesquire
dougiesquire previously approved these changes Feb 14, 2025
Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the AccessOm3 driver again and now works as expected. Maybe worth waiting for approval from a real Payu developer before merging though.

jo-basevi
jo-basevi previously approved these changes Feb 17, 2025
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me - thanks @anton-seaice!

jo-basevi
jo-basevi previously approved these changes Feb 19, 2025
@anton-seaice
Copy link
Contributor Author

Its me again ... needing something approved again :-)

dougiesquire
dougiesquire previously approved these changes Feb 20, 2025
@anton-seaice
Copy link
Contributor Author

This is ready to go (again!) @dougiesquire

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anton-seaice. Looks good to me and tested successfully

@anton-seaice anton-seaice merged commit 39e4b9b into master Feb 20, 2025
8 checks passed
@anton-seaice anton-seaice deleted the 565-commit-momdocs branch February 20, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit _MOM_parameter_docs_ in access-om3 driver
6 participants