Skip to content

Commit

Permalink
disabling health endpoint smoke test
Browse files Browse the repository at this point in the history 
it’s not in use.
  • Loading branch information
@daveshanley
daveshanley committed Jan 22, 2025
1 parent 8fa2e61 commit 9f3b876
Showing 1 changed file with 161 additions and 162 deletions.
323 changes: 161 additions & 162 deletions plank/pkg/server/server_smoke_test.go
View file
Original file line number Diff line number Diff line change
@@ -1,181 +1,180 @@
package server

import (
"crypto/tls"
"fmt"
"github.com/pb33f/ranch/bus"
"github.com/pb33f/ranch/service"
"github.com/stretchr/testify/assert"
"io/ioutil"
"net/http"
"os"
"path/filepath"
"sync"
"testing"
"crypto/tls"
"fmt"
"github.com/pb33f/ranch/bus"
"github.com/pb33f/ranch/service"
"github.com/stretchr/testify/assert"
"net/http"
"os"
"path/filepath"
"sync"
"testing"
)

// TestSmokeTests_TLS tests if Plank starts with TLS enabled
func TestSmokeTests_TLS(t *testing.T) {
// pre-arrange
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

// arrange
port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "null", "stderr", port, true)
cfg.FabricConfig = GetTestFabricBrokerConfig()
cfg.TLSCertConfig = GetTestTLSCertConfig(testRoot)

// act
var wg sync.WaitGroup
sigChan := make(chan os.Signal)
baseUrl, _, testServer := CreateTestServer(cfg)
testServerInternal := testServer.(*platformServer)
testServerInternal.setEventBusRef(newBus)

// assert to make sure the server was created with the correct test arguments
assert.EqualValues(t, fmt.Sprintf("https://localhost:%d", port), baseUrl)

wg.Add(1)
go testServer.StartServer(sigChan)

originalTransport := http.DefaultTransport
originalTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}

RunWhenServerReady(t, newBus, func(t *testing.T) {
resp, err := http.Get(baseUrl)
if err != nil {
defer func() {
testServer.StopServer()
wg.Done()
}()
t.Fatal(err)
}
assert.EqualValues(t, http.StatusNotFound, resp.StatusCode)
testServer.StopServer()
wg.Done()
})
wg.Wait()
// pre-arrange
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

// arrange
port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "null", "stderr", port, true)
cfg.FabricConfig = GetTestFabricBrokerConfig()
cfg.TLSCertConfig = GetTestTLSCertConfig(testRoot)

// act
var wg sync.WaitGroup
sigChan := make(chan os.Signal)
baseUrl, _, testServer := CreateTestServer(cfg)
testServerInternal := testServer.(*platformServer)
testServerInternal.setEventBusRef(newBus)

// assert to make sure the server was created with the correct test arguments
assert.EqualValues(t, fmt.Sprintf("https://localhost:%d", port), baseUrl)

wg.Add(1)
go testServer.StartServer(sigChan)

originalTransport := http.DefaultTransport
originalTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true}

RunWhenServerReady(t, newBus, func(t *testing.T) {
resp, err := http.Get(baseUrl)
if err != nil {
defer func() {
testServer.StopServer()
wg.Done()
}()
t.Fatal(err)
}
assert.EqualValues(t, http.StatusNotFound, resp.StatusCode)
testServer.StopServer()
wg.Done()
})
wg.Wait()
}

// TestSmokeTests_TLS_InvalidCert tests if Plank fails to start because of an invalid cert
func TestSmokeTests_TLS_InvalidCert(t *testing.T) {
// TODO: make StartServer return an error object so it's easier to test
// TODO: make StartServer return an error object so it's easier to test
}

func TestSmokeTests(t *testing.T) {
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
//testOutFile := filepath.Join(testRoot, "plank-server-tests.log")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
cfg.NoBanner = true
cfg.FabricConfig = GetTestFabricBrokerConfig()

baseUrl, _, testServer := CreateTestServer(cfg)
testServer.(*platformServer).eventbus = newBus

assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)

syschan := make(chan os.Signal, 1)
wg := sync.WaitGroup{}
wg.Add(1)
go testServer.StartServer(syschan)
RunWhenServerReady(t, newBus, func(t *testing.T) {
// root url - 404
t.Run("404 on root", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(baseUrl)
assert.Nil(t2, err)
assert.EqualValues(t2, 404, rsp.StatusCode)
})

// connection to fabric endpoint
t.Run("fabric endpoint should exist", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(fmt.Sprintf("%s/ws", baseUrl))
assert.Nil(t2, err)
assert.EqualValues(t2, 400, rsp.StatusCode)
})

testServer.StopServer()
wg.Done()
})
wg.Wait()
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
//testOutFile := filepath.Join(testRoot, "plank-server-tests.log")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
cfg.NoBanner = true
cfg.FabricConfig = GetTestFabricBrokerConfig()

baseUrl, _, testServer := CreateTestServer(cfg)
testServer.(*platformServer).eventbus = newBus

assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)

syschan := make(chan os.Signal, 1)
wg := sync.WaitGroup{}
wg.Add(1)
go testServer.StartServer(syschan)
RunWhenServerReady(t, newBus, func(t *testing.T) {
// root url - 404
t.Run("404 on root", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(baseUrl)
assert.Nil(t2, err)
assert.EqualValues(t2, 404, rsp.StatusCode)
})

// connection to fabric endpoint
t.Run("fabric endpoint should exist", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(fmt.Sprintf("%s/ws", baseUrl))
assert.Nil(t2, err)
assert.EqualValues(t2, 400, rsp.StatusCode)
})

testServer.StopServer()
wg.Done()
})
wg.Wait()
}

func TestSmokeTests_NoFabric(t *testing.T) {
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
cfg.FabricConfig = nil
baseUrl, _, testServer := CreateTestServer(cfg)
testServer.(*platformServer).eventbus = newBus

assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)

syschan := make(chan os.Signal, 1)
wg := sync.WaitGroup{}
wg.Add(1)
go testServer.StartServer(syschan)
RunWhenServerReady(t, newBus, func(t *testing.T) {
// fabric - 404
t.Run("404 on fabric endpoint", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(fmt.Sprintf("%s/ws", baseUrl))
assert.Nil(t2, err)
assert.EqualValues(t2, 404, rsp.StatusCode)
})

testServer.StopServer()
wg.Done()
})
wg.Wait()
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
cfg.FabricConfig = nil
baseUrl, _, testServer := CreateTestServer(cfg)
testServer.(*platformServer).eventbus = newBus

assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)

syschan := make(chan os.Signal, 1)
wg := sync.WaitGroup{}
wg.Add(1)
go testServer.StartServer(syschan)
RunWhenServerReady(t, newBus, func(t *testing.T) {
// fabric - 404
t.Run("404 on fabric endpoint", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(fmt.Sprintf("%s/ws", baseUrl))
assert.Nil(t2, err)
assert.EqualValues(t2, 404, rsp.StatusCode)
})

testServer.StopServer()
wg.Done()
})
wg.Wait()
}

func TestSmokeTests_HealthEndpoint(t *testing.T) {
newBus := bus.ResetBus()
service.ResetServiceRegistry()
testRoot := filepath.Join(os.TempDir(), "plank-tests")
_ = os.MkdirAll(testRoot, 0755)
defer os.RemoveAll(testRoot)

port := GetTestPort()
cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
cfg.FabricConfig = nil
baseUrl, _, testServer := CreateTestServer(cfg)
testServer.(*platformServer).eventbus = newBus

assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)

syschan := make(chan os.Signal, 1)
wg := sync.WaitGroup{}
wg.Add(1)
go testServer.StartServer(syschan)
RunWhenServerReady(t, newBus, func(*testing.T) {
t.Run("/health returns OK", func(t2 *testing.T) {
cl := http.DefaultClient
rsp, err := cl.Get(fmt.Sprintf("%s/health", baseUrl))
assert.Nil(t2, err)
defer rsp.Body.Close()
bodyBytes, _ := ioutil.ReadAll(rsp.Body)
assert.Contains(t, string(bodyBytes), "OK")
})

testServer.StopServer()
wg.Done()
})
wg.Wait()
}
//func TestSmokeTests_HealthEndpoint(t *testing.T) {
// newBus := bus.ResetBus()
// service.ResetServiceRegistry()
// testRoot := filepath.Join(os.TempDir(), "plank-tests")
// _ = os.MkdirAll(testRoot, 0755)
// defer os.RemoveAll(testRoot)
//
// port := GetTestPort()
// cfg := GetBasicTestServerConfig(testRoot, "stdout", "stdout", "stderr", port, true)
// cfg.FabricConfig = nil
// baseUrl, _, testServer := CreateTestServer(cfg)
// testServer.(*platformServer).eventbus = newBus
//
// assert.EqualValues(t, fmt.Sprintf("http://localhost:%d", port), baseUrl)
//
// syschan := make(chan os.Signal, 1)
// wg := sync.WaitGroup{}
// wg.Add(1)
// go testServer.StartServer(syschan)
// RunWhenServerReady(t, newBus, func(*testing.T) {
// t.Run("/health returns OK", func(t2 *testing.T) {
// cl := http.DefaultClient
// rsp, err := cl.Get(fmt.Sprintf("%s/health", baseUrl))
// assert.Nil(t2, err)
// defer rsp.Body.Close()
// bodyBytes, _ := ioutil.ReadAll(rsp.Body)
// assert.Contains(t, string(bodyBytes), "OK")
// })
//
// testServer.StopServer()
// wg.Done()
// })
// wg.Wait()
//}

0 comments on commit 9f3b876

Please sign in to comment.