Add deletion of uploaded images

[jschulzaqua]

If you upload images, you can unfortunately no longer remove them from the selection.
Is there a solution for this?

[wmnnd]

There’s currently no way to delete files because before adding this feature, I wanted to add a check whether a file is currently in use in another campaign. But this is definitely something for the to-do list!

[wmnnd]

Hey there, thanks for giving this a shot!

One of the reasons (as mentioned in #374) why I hadn't implemented this feature yet is that I think there should be a check whether an image is still in use in other campaigns. There should be a warning when deleting an image that's still in use somewhere because it might break campaigns that have already been sent (bad) or campaigns that have been created but not yet sent (not quite as bad but still not good).

I was thinking we should add something like Keila.Mailings.search_in_project_campaigns(project_id, string). Then this function should search for the given string in text_body, mjml_body, html_bodyand json_body. You could then use this function to check if there are any campaigns where the full path or the UUID of the file occurs.
Let me know what you think and if you'd like to try your hand at this as well!

Another thing you should do is make sure the user has permission to delete the file they're trying to delete. To do that, you could add Keila.Files.get_project_file(project_id, file_id) to ensure the UUID sent by the user is part of their project. Only if it does exist, should you call delete_file/2.

[jrowah]

Hey, thank you for responding.

I think your idea of implementation is better. I would like to give it a shot and will let you know if I think of something.
I also missed the security measure you mentioned in the last part, I am on to that as well.

[wmnnd]

Awesome! Let me know if you come across anything where I can help 😊

[MrSnoozles]

@wmnnd Would it be easier to manage if images get copied (either to another directory or they get a "keila-sent-" prefix) as soon as the campaign is being sent out? Then all the uploaded images could be deleted. If they are used in a campaign the copy is still there.

(That would not work for campaigns already sent before the release of this feature though, but since Keila hasn't reached 1.0 yet that might be okay?)

[wmnnd]

Thanks for the idea @MrSnoozles. I think It might be the better solution in the long run but I don't think implementing it makes sense before #355 is complete.