Skip to content

PMM-13953: re-use passed in logger #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

PMM-13953: re-use passed in logger #1074

merged 1 commit into from
Apr 28, 2025

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Apr 28, 2025

PMM-13953

  • Links to related pull requests (optional).

Below we provide a basic checklist of things that would make it a good PR:

  • Make sure to sign the CLA (Contributor License Agreement).
  • Make sure all tests pass.
  • Keep current with the target branch and fix conflicts if necessary.
  • Update jira ticket description if necessary.
  • Attach screenshots and/or console output to the jira ticket to confirm new behavior, if applicable.
  • Leave notes to the reviewers if you need to focus their attention on something specific.

Once all checks pass and the code is ready for review, please add pmm-review-exporters team as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.

@idoqo idoqo requested a review from a team as a code owner April 28, 2025 09:31
@idoqo idoqo requested review from ademidoff and BupycHuk and removed request for a team April 28, 2025 09:31
@idoqo idoqo merged commit d3bd2f1 into main Apr 28, 2025
14 checks passed
@idoqo idoqo deleted the PMM-13953-fix-logger branch April 28, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants