Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13458 Expose Nomad API #3630

Open
wants to merge 4 commits into
base: v3
Choose a base branch
from
Open

PMM-13458 Expose Nomad API #3630

wants to merge 4 commits into from

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Feb 11, 2025

PMM-13458

Link to the Feature Build: SUBMODULES-3481

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@ademidoff ademidoff changed the base branch from main to v3 February 11, 2025 20:08
@ademidoff ademidoff closed this Feb 11, 2025
@ademidoff ademidoff deleted the PMM-13458-expose-nomad-api branch February 11, 2025 20:09
@ademidoff ademidoff restored the PMM-13458-expose-nomad-api branch February 11, 2025 20:09
@ademidoff ademidoff reopened this Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (v3@95afe77). Learn more about missing BASE report.

Files with missing lines Patch % Lines
managed/services/server/server.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #3630   +/-   ##
=====================================
  Coverage      ?   43.64%           
=====================================
  Files         ?      366           
  Lines         ?    44320           
  Branches      ?        0           
=====================================
  Hits          ?    19343           
  Misses        ?    23294           
  Partials      ?     1683           
Flag Coverage Δ
admin 11.47% <ø> (?)
agent 51.98% <ø> (?)
managed 45.40% <50.00%> (?)
vmproxy 68.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review February 11, 2025 21:05
@ademidoff ademidoff requested a review from a team as a code owner February 11, 2025 21:05
@ademidoff ademidoff requested review from BupycHuk and idoqo and removed request for a team February 11, 2025 21:05
@ademidoff
Copy link
Member Author

@dependabot rebase

LOL, dependabot in not an author here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants