PMM-7 Bump up the runner to latest #3634
Conversation
ademidoff
requested review from
a team,
yurkovychv,
BupycHuk,
talhabinrizwan,
idoqo and
JiriCtvrtka
as code owners
.github/workflows/dependabot.yml
Outdated
| @@ -8,7 +8,7 @@ permissions: | |||
| jobs: | |||
| dependabot: | |||
| name: Enable auto-merge | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
shouldn't it be 22.04 like in other jobs?
There was a problem hiding this comment.
shouldn't it be 22.04 like in other jobs?
Yeah, it's a good question! What's wrong with the latest? Why do we need to worry about bumping up?
There was a problem hiding this comment.
Franky, I'd migrate them all to latest and forget about it.
There was a problem hiding this comment.
sometimes it might lead to unexpected failures
There was a problem hiding this comment.
Do we really have any examples at all?
There was a problem hiding this comment.
I'm sure dependabot will just work, because both the runner and the actor are from the same vendor :)
There was a problem hiding this comment.
Btw, even if we pin the version, there is never a guarantee, since runners also get updated regularly without us noticing it... but they still work 🤞
There was a problem hiding this comment.
actions/runner-images#10788
actions/runner-images#2234
https://exercism.org/docs/building/github/gha-best-practices#h-pin-test-runners-to-version
I'm sure that you are right about this case and that action will keep working, but behavior might change when new ubuntu will come with new node version and this action will still be using old node version.
There was a problem hiding this comment.
Sorry, the examples above are irrelevant IMO. Again, the runner and the bot are maintained by the same company.
On the other hand this problem is so minor, that I don't see why we should sweat over it more than that, so I concur.
ademidoff
temporarily deployed
to
PMM-7-migrate-the-runner-to-latest - pmm-doc-2 PR #3634
Render
Destroyed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3634 +/- ##
=====================================
Coverage ? 43.64%
=====================================
Files ? 366
Lines ? 44320
Branches ? 0
=====================================
Hits ? 19342
Misses ? 23296
Partials ? 1682
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PMM-7
We are bumping up the dependabot's runner due to its forthcoming deprecation:
"The Ubuntu 20.04 runner image will be fully unsupported by April 1, 2025"
After the deprecation deadline, the actions will be blocked.