Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmproxy: always set Host header from VMURL #3636

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

r3code
Copy link

@r3code r3code commented Feb 12, 2025

closes #3635

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@r3code r3code requested a review from a team as a code owner February 12, 2025 11:53
@r3code r3code requested review from idoqo and JiriCtvrtka and removed request for a team February 12, 2025 11:53
@r3code r3code force-pushed the vmproxy-set-host-from-target-url branch from 467fc26 to 63a1270 Compare February 13, 2025 07:15
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3@d5d500b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
vmproxy/proxy/proxy.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #3636   +/-   ##
=====================================
  Coverage      ?   43.67%           
=====================================
  Files         ?      366           
  Lines         ?    44328           
  Branches      ?        0           
=====================================
  Hits          ?    19360           
  Misses        ?    23287           
  Partials      ?     1681           
Flag Coverage Δ
vmproxy 73.45% <91.42%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JiriCtvrtka JiriCtvrtka enabled auto-merge (squash) February 13, 2025 11:06
@JiriCtvrtka JiriCtvrtka merged commit 8e86eea into percona:v3 Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants