Dev min dist fix #25
Open
Dev min dist fix #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.1.4 Patch Release
sgsutcliffe
reviewed
Feb 19, 2025
| d = float(line[2]) | ||
| #print(f'{qid} {rid} {d}') |
There was a problem hiding this comment.
Guessing this a vestige of testing
sgsutcliffe
reviewed
Feb 19, 2025
| @@ -200,21 +198,21 @@ def assign(self, n_records=1000,delim="\t"): | |||
| addr_members = self.memberships_lookup[addr] | |||
| addr_dists = [] | |||
| for id in addr_members: | |||
| addr_dists.append(dists[qid][id]) | |||
| if id in dists[qid]: | |||
There was a problem hiding this comment.
So it is still useful to remove the samples with distances below minimum threshold, and use this to avoid the key error?
sgsutcliffe
reviewed
Feb 19, 2025
| self.add_memberships_lookup(qid, query_addr) | ||
| #self.memberships_dict[qid] = ".".join([str(x) for x in query_addr]) |
There was a problem hiding this comment.
Do we want to remove the commented code out now that it is moved to the function? or is this a helpful reminder of what was changed?
|
I think it looks good. I went through it and nothing stood out. Always a good sign! Should we come up with tests for these alternate scenarios that broke the orginal assumptions? |
sgsutcliffe
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes address several issues which occured with a different dataset.