Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bars #953

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Progress Bars #953

wants to merge 19 commits into from

Conversation

ChrisHuynh333
Copy link
Collaborator

@ChrisHuynh333 ChrisHuynh333 commented Feb 18, 2025

What does this PR do and why?

This PR is for STRY0016844 and adds progress bars to the UI to give users feedback on the progression of their background tasks.
Progress bars have been added to copying samples, transferring samples, and importing metadata (project and group levels).

Screenshots or screen recordings

Screencast.from.2025-02-19.10.28.52.AM.webm

How to set up and validate locally

  1. Test copying and transferring samples, as well as importing metadata (at the project and group level), and verify the progress bars work and provide the expected feedback (eg: they increase smoothly and don't 'backtrack' throughout the progression).
  2. Induce errors for these actions, and ensure error messages are still displayed as expected.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

This comment has been minimized.

@ChrisHuynh333 ChrisHuynh333 self-assigned this Feb 19, 2025
@ChrisHuynh333 ChrisHuynh333 marked this pull request as ready for review February 19, 2025 17:20
@ChrisHuynh333 ChrisHuynh333 added ready for review Pull request is ready for review on hold and removed ready for review Pull request is ready for review labels Feb 19, 2025
@ChrisHuynh333 ChrisHuynh333 added ready for review Pull request is ready for review and removed on hold labels Feb 24, 2025

This comment has been minimized.

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. Thank you for trying out some of my suggestions. Left a couple comments, and still need to go through it a bit more.

This comment has been minimized.

This comment has been minimized.

Copy link

Code Metrics Report

Coverage Test Execution Time
93.3% 11m18s

Code coverage of files in pull request scope (100.0%)

Files Coverage
app/components/viral/dialog/header_component.html.erb 100.0%
app/components/viral/progress_bar_component.html.erb 100.0%
app/components/viral/progress_bar_component.rb 100.0%
app/controllers/concerns/file_import_actions.rb 100.0%
app/controllers/projects/samples/clones_controller.rb 100.0%
app/controllers/projects/samples/transfers_controller.rb 100.0%
app/helpers/view_helper.rb 100.0%
app/jobs/samples/clone_job.rb 100.0%
app/jobs/samples/metadata_import_job.rb 100.0%
app/jobs/samples/transfer_job.rb 100.0%
app/services/base_service.rb 100.0%
app/services/samples/clone_service.rb 100.0%
app/services/samples/metadata/file_import_service.rb 100.0%
app/services/samples/transfer_service.rb 100.0%
app/views/groups/samples/metadata/file_imports/create.turbo_stream.erb 100.0%
app/views/groups/samples/metadata/file_imports/new.turbo_stream.erb 100.0%
app/views/projects/samples/clones/_dialog.html.erb 100.0%
app/views/projects/samples/clones/create.turbo_stream.erb 100.0%
app/views/projects/samples/clones/new.turbo_stream.erb 100.0%
app/views/projects/samples/metadata/_form.html.erb 100.0%
app/views/projects/samples/metadata/file_imports/create.turbo_stream.erb 100.0%
app/views/projects/samples/metadata/file_imports/new.turbo_stream.erb 100.0%
app/views/projects/samples/shared/_success.html.erb 100.0%
app/views/projects/samples/transfers/_dialog.html.erb 100.0%
app/views/projects/samples/transfers/create.turbo_stream.erb 100.0%
app/views/projects/samples/transfers/new.turbo_stream.erb 100.0%
app/views/shared/samples/metadata/file_imports/_dialog.html.erb 100.0%
app/views/shared/samples/metadata/file_imports/_success.html.erb 100.0%

Reported by octocov

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants