Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata import: Column selection #957

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Feb 19, 2025

What does this PR do and why?

Added a list of metadata columns to the file import dialog.
STRY0016737

Screenshots or screen recordings

image

How to set up and validate locally

Enable the new feature:

  1. Launch rails console and run the following:
Flipper.enable(:metadata_import_field_selection)
  1. Launch a browser and navigate to http://localhost:3000/rails/flipper/features to verify the feature has been enabled.

Test the new feature:

  1. Navigate to a samples page that the logged in user has access to update.
  2. Hit the Import Metadata button.
  3. Select a file to import.
  4. Select the Sample ID Column.
  5. Select the Metadata Columns.
  6. Hit the Import Metadata button.
  7. Verify the sample metadata was updated.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@ksierks ksierks self-assigned this Feb 19, 2025
@ksierks ksierks force-pushed the metadata-import-columns branch from aee744e to c4ebe05 Compare February 20, 2025 15:08

This comment has been minimized.

@ksierks ksierks force-pushed the metadata-import-columns branch 2 times, most recently from 11e7fd3 to 4128a6b Compare February 25, 2025 20:51
Copy link

Code Metrics Report

Coverage Test Execution Time
93.2% 10m36s

Code coverage of files in pull request scope (99.0%)

Files Coverage
app/controllers/concerns/file_import_actions.rb 100.0%
app/services/samples/metadata/file_import_service.rb 98.0%
app/views/shared/samples/metadata/file_imports/_dialog.html.erb 100.0%

Reported by octocov

@ksierks ksierks force-pushed the metadata-import-columns branch from 4128a6b to 730f987 Compare February 26, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant