Deps: axe-core 4.10 #966
Open
Deps: axe-core 4.10 #966
+9
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericenns
force-pushed
the
deps/axe-core-4.10
branch
from
c41ce00 to
5b567ca
Compare
joshsadam
requested changes
Feb 26, 2025
| @@ -15,7 +15,7 @@ | |||
| </style> | |||
| </head> | |||
| <body class="bg-slate-50 dark:bg-slate-900"> | |||
| <div class="grid h-screen place-items-center"> | |||
| <div role="main" class="grid h-screen place-items-center"> | |||
There was a problem hiding this comment.
question: Why not just make the element main (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/main)
| @@ -8,6 +8,7 @@ | |||
| </head> | |||
| <body class="bg-white dark:bg-slate-900"> | |||
| <div | |||
| role="main" | |||
Code Metrics Report
Code coverage of files in pull request scope (100.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
Upgrades axe-core to 4.10 and enables all rules to be tested.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.