-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed metadata fields #149
base: dev
Are you sure you want to change the base?
Conversation
This PR is against the
|
|
In order to add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @dfornika, this is awesome work 😄.
For your question on qc_status_read_length
, that is a good point about adding a parameter for min_mean_read_length
. @mattheww95 is this something that already exists in mikrokondo? As in a check to make sure the mean read length is over a threshold?
"RawReadSummary.R1.mean_sequence_length" : "Mean Sequence Length Forward", | ||
"RawReadSummary.R2.mean_sequence_length" : "Mean Sequence Length Reverse", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you align this with the other text (I assume there's a tab here where there should be spaces).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just following up on this PR. I reached out to @dfornika to mention that I can finish off this PR for him. I just had to wrap something else up.
I did have some questions related to the two new fields, the average read length one will not be too hard to add. But I want to verify some of the requirements for the new fields.
Renaming metadata field names as requested by @apetkau and @jrober84 (see Issue #148)
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).