forked from connor-lab/ncov2019-artic-nf
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update artic to version 1.6.1 #101
Open
DarianHole
wants to merge
12
commits into
master
Choose a base branch
from
update/artic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r3 models) and check_model (checks to make sure the clair3 model can be automatically selected using information in the fastq headers or the clair3 parameter has been set). Added a dummy channel output from check_model to articMinION, so they do not run concurrently. Modified the artic command in articMinION to use clair3. The model parameter is added conditionally to the artic command if it is set (defaults to null). Removed medaka mentions.
DarianHole
commented
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Amber! Some quick comments
DarianHole
commented
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the artic version to utilize the new features and variant calling with clair3
This DOES require parameter adjustments that are breaking so the version is going to 3.0.0.
Some parts to finish:
--model
--model <str>
or--model-dir <path>
Closes #100