Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artic to version 1.6.1 #101

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update artic to version 1.6.1 #101

wants to merge 12 commits into from

Conversation

DarianHole
Copy link
Member

@DarianHole DarianHole commented Feb 7, 2025

Updating the artic version to utilize the new features and variant calling with clair3

This DOES require parameter adjustments that are breaking so the version is going to 3.0.0.

Some parts to finish:

  • Parameter addition to optional --model
    • See if its a string or path to determine with artic parameter is used, --model <str> or --model-dir <path>
    • If no model given it'll detect best which is ok but needs code for it
  • Docs updates
    • Removal of medaka mentions
    • Removal of nanopolish mentions
    • Addition of artic validation quick report
      • Link to artic if needed
  • Test the updates (need to actually rewrite the tests at some point)

Closes #100

DarianHole and others added 4 commits February 7, 2025 11:50
…r3 models) and check_model (checks to make sure the clair3 model can be automatically selected using information in the fastq headers or the clair3 parameter has been set). Added a dummy channel output from check_model to articMinION, so they do not run concurrently. Modified the artic command in articMinION to use clair3. The model parameter is added conditionally to the artic command if it is set (defaults to null). Removed medaka mentions.
Copy link
Member Author

@DarianHole DarianHole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amber! Some quick comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Artic version
2 participants