Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a non-credentialed deployment #703

Merged
merged 28 commits into from
Jan 12, 2024
Merged

Conversation

Jeff-Thompson12
Copy link
Collaborator

Addresses #700

@Jeff-Thompson12 Jeff-Thompson12 changed the base branch from master to dev November 16, 2023 18:48
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (12e418d) 78.12% compared to head (b6fb751) 77.19%.

Files Patch % Lines
R/mod_user_roles.R 1.09% 90 Missing ⚠️
R/app_server.R 33.33% 6 Missing ⚠️
R/mod_decision_automation.R 61.53% 5 Missing ⚠️
R/mod_reportPreview.R 40.00% 3 Missing ⚠️
R/utils_config_db.R 50.00% 3 Missing ⚠️
R/utils_startup.R 81.81% 2 Missing ⚠️
R/mod_addComment.R 75.00% 1 Missing ⚠️
R/mod_communityMetrics.R 50.00% 1 Missing ⚠️
R/mod_introJS.R 50.00% 1 Missing ⚠️
R/mod_maintenanceMetrics.R 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #703      +/-   ##
==========================================
- Coverage   78.12%   77.19%   -0.94%     
==========================================
  Files          33       33              
  Lines        4897     4964      +67     
==========================================
+ Hits         3826     3832       +6     
- Misses       1071     1132      +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeff-Thompson12 Jeff-Thompson12 marked this pull request as ready for review November 30, 2023 14:37
@AARON-CLARK
Copy link
Collaborator

@Jeff-Thompson12, after recent merges, there is now a conflict on this branch.

Merge branch 'dev' into jt-700-noncredential_deploy

# Conflicts:
#	NEWS.md
#	R/utils_startup.R
@AARON-CLARK
Copy link
Collaborator

I think this looks really good. The only thing I would advise is to test out creating roles within our Posit Connect environment before merging. That way, we can see if they behave as we expect them to.

Nice work!

Merge branch 'dev' into jt-700-noncredential_deploy

# Conflicts:
#	NEWS.md
Merge branch 'dev' into jt-700-noncredential_deploy

# Conflicts:
#	NEWS.md
#	R/utils_startup.R
Merge branch 'dev' into jt-700-noncredential_deploy

# Conflicts:
#	NEWS.md
Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@AARON-CLARK AARON-CLARK merged commit d902f3c into dev Jan 12, 2024
3 checks passed
@AARON-CLARK AARON-CLARK deleted the jt-700-noncredential_deploy branch January 17, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants