Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Package Dependencies to Reports #723

Closed
wants to merge 46 commits into from

Conversation

Robert-Krajcik
Copy link
Contributor

Closes issue #721

@Robert-Krajcik Robert-Krajcik self-assigned this Dec 7, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4a6e690) 78.13% compared to head (37e57c7) 79.29%.

❗ Current head 37e57c7 differs from pull request most recent head 63061ec. Consider uploading reports for the commit 63061ec to get more accurate results

Files Patch % Lines
R/app_server.R 85.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #723      +/-   ##
==========================================
+ Coverage   78.13%   79.29%   +1.16%     
==========================================
  Files          33       33              
  Lines        4876     4937      +61     
==========================================
+ Hits         3810     3915     +105     
+ Misses       1066     1022      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robert-Krajcik Robert-Krajcik marked this pull request as ready for review December 13, 2023 16:57
@AARON-CLARK
Copy link
Collaborator

Hi @Robert-Krajcik, I see this PR is failing r-cmd-check and test-coverage. Those need to get resolved, but I will review anyway. Stay tuned!

Copy link
Collaborator

@AARON-CLARK AARON-CLARK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output

I noticed in the Build Report tab and the HTML report, there is an extra column showing up called "Name". I think that could be removed since we already have the "Package" column, keeping it consistent with the Package Dependencies tab.

Package Dependencies Tab:

image

Build Reports Tab & HTML report:

image

The DOCX report:
This looks a little funny in word since there is a multi-line summary being displayed. Perhaps you can play with a way to clean this up? Maybe alter the word styler file... which we don't have in the repo. Do you know what I'm talking about? Happy to provide more context. Just let me know.

image

Suggests

Also, there is no option to include or exclude "Suggests" in this table. Honestly, this is something that I would love to be controlled from the config file (related to #720), but in the app, we can give users the option to choose "with" or "without Suggests"? How about if the "Package Dependencies" report config is selected, another material switch appears (similar to the one below) that asks users to include suggests. Perhaps it maintains state from the Package Dependencies tab.... or not if that's too tricky.

image

Score

I also feel like the score column can be a little confusing, but only because it's not well defined. Do users know: if there is no score present in the DB, there is no score? A potential solution would be to fill these cells with "Not Assessed" or "Not uploaded". I'm open to suggestions!

whoops

Last, this is not your problem, but I just realized the meter's color hasn't been changed in the downloadable HTML report yet (see below). I'll create a separate issue for that.
image

@Robert-Krajcik
Copy link
Contributor Author

Redundant with #734 which was merged yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants