-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Package Dependencies to Reports #723
Conversation
`v3.0.0` quick fixes
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #723 +/- ##
==========================================
+ Coverage 78.13% 79.29% +1.16%
==========================================
Files 33 33
Lines 4876 4937 +61
==========================================
+ Hits 3810 3915 +105
+ Misses 1066 1022 -44 ☔ View full report in Codecov by Sentry. |
Hi @Robert-Krajcik, I see this PR is failing r-cmd-check and test-coverage. Those need to get resolved, but I will review anyway. Stay tuned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output
I noticed in the Build Report
tab and the HTML report, there is an extra column showing up called "Name". I think that could be removed since we already have the "Package" column, keeping it consistent with the Package Dependencies
tab.
Package Dependencies
Tab:
Build Reports
Tab & HTML report:
The DOCX report:
This looks a little funny in word since there is a multi-line summary being displayed. Perhaps you can play with a way to clean this up? Maybe alter the word styler file... which we don't have in the repo. Do you know what I'm talking about? Happy to provide more context. Just let me know.
Suggests
Also, there is no option to include or exclude "Suggests" in this table. Honestly, this is something that I would love to be controlled from the config file (related to #720), but in the app, we can give users the option to choose "with" or "without Suggests"? How about if the "Package Dependencies" report config is selected, another material switch appears (similar to the one below) that asks users to include suggests. Perhaps it maintains state from the Package Dependencies tab.... or not if that's too tricky.
Score
I also feel like the score column can be a little confusing, but only because it's not well defined. Do users know: if there is no score present in the DB, there is no score? A potential solution would be to fill these cells with "Not Assessed" or "Not uploaded". I'm open to suggestions!
whoops
Last, this is not your problem, but I just realized the meter's color hasn't been changed in the downloadable HTML report yet (see below). I'll create a separate issue for that.
Redundant with #734 which was merged yesterday. |
Closes issue #721