Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency metric tab #740

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Fix dependency metric tab #740

merged 3 commits into from
Jan 17, 2024

Conversation

Jeff-Thompson12
Copy link
Collaborator

Addresses #739

@Jeff-Thompson12
Copy link
Collaborator Author

I did not update the NEWS since this bug was not introduced on the master branch.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8e5f638) 79.33% compared to head (165fc29) 79.27%.

Files Patch % Lines
R/mod_packageDependencies.R 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #740      +/-   ##
==========================================
- Coverage   79.33%   79.27%   -0.07%     
==========================================
  Files          33       33              
  Lines        5018     5022       +4     
==========================================
  Hits         3981     3981              
- Misses       1037     1041       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Robert-Krajcik Robert-Krajcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Jeff.

@Jeff-Thompson12 Jeff-Thompson12 merged commit 4cfdbfb into dev Jan 17, 2024
3 checks passed
@Jeff-Thompson12 Jeff-Thompson12 deleted the jt-739-fix_dep_tab branch January 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants