Ni 707 add waiting screen

[narayanan-iyer-pfizer]

By using Archive library, I have refactored the code in code explorer, package explorer to read tarballs in memory

[AARON-CLARK]

@AARON-CLARK will take a look at tests... And @Jeff-Thompson12 volunteers too!

[Jeff-Thompson12]

@narayanan-iyer-pfizer I pushed a couple commits that should help you out with dealing with the errors. It seems like the main issue now is that archive is returning a different directory tree than what one would expect if the tarball was unpacked. Mainly the difference is that the directory is no longer being returned in alphabetical order which I think we would want.

[narayanan-iyer-pfizer]

@narayanan-iyer-pfizer I pushed a couple commits that should help you out with dealing with the errors. It seems like the main issue now is that archive is returning a different directory tree than what one would expect if the tarball was unpacked. Mainly the difference is that the directory is no longer being returned in alphabetical order which I think we would want.
Thanks ! I have updated code to sort it . Still the tests seems to failing

[codecov]

Codecov Report

Attention: Patch coverage is 88.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 79.34%. Comparing base (bdcbffc) to head (b1a618d).

Files	Patch %	Lines
R/mod_code_explorer.R	77.14%	8 Missing ⚠️
R/mod_code_explorer_utils.R	95.45%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #756      +/-   ##
==========================================
+ Coverage   79.23%   79.34%   +0.10%     
==========================================
  Files          33       33              
  Lines        5028     5063      +35     
==========================================
+ Hits         3984     4017      +33     
- Misses       1044     1046       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Jeff-Thompson12]

@narayanan-iyer-pfizer I love this PR. Few comments:

• General spacing and formatting of function calls. We don't have a formal style, but all of the other code has consistent spacing (and I personally find it easier to read).
• Using reactives in a function. I can be swayed on this but I personally think the value of a reactive should be passed in functions and not the reactive itself.

[narayanan-iyer-pfizer]

Changes made to address the requests. Tests are still failing , pls take a look.thanks

[Jeff-Thompson12]

@narayanan-iyer-pfizer I am getting some console warnings when viewing help documents in the file explorer. Can you take a look?

[narayanan-iyer-pfizer]

@narayanan-iyer-pfizer I am getting some console warnings when viewing help documents in the file explorer. Can you take a look?

this has been addressed in a different way

[Jeff-Thompson12]

@narayanan-iyer-pfizer I am getting some console warnings when viewing help documents in the file explorer. Can you take a look?

this has been addressed in a different way

Marvelous. I love it.

@AARON-CLARK did you want to take a look at this PR? My additions were fairly minor, but since I did contribute, I wasn't sure if you wanted an additional pair of eyes on it.

[AARON-CLARK]

did you want to take a look at this PR?

Normally, No! I trust you. But I had a minute so I just pulled it open to test anyway (lol). The source explorer is lightning fast now! Great work @narayanan-iyer-pfizer! And thanks @Jeff-Thompson12 for contributing.