Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user name to batch upload #792

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

Closes #785

@jthompson-arcus
Copy link
Collaborator Author

User name is now added as a parenthetical to the batch upload designation.
image

@jthompson-arcus jthompson-arcus marked this pull request as ready for review June 17, 2024 13:16
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as-is. The only change I'd suggest is allowing users to make a decision when using upload_pkg_list() but I think that task can be saved for another day! I'll create a new issue for it. Thanks!

@aclark02-arcus aclark02-arcus merged commit 5d61fab into dev Jun 17, 2024
1 check passed
@jthompson-arcus
Copy link
Collaborator Author

This looks good as-is. The only change I'd suggest is allowing users to make a decision when using upload_pkg_list() but I think that task can be saved for another day! I'll create a new issue for it. Thanks!

Like if is.null(user_name) then just record it as Batch Upload instead of defaulting to Batch Upload (system)?

@jthompson-arcus jthompson-arcus deleted the jt-785_attach_user_name_batch_upload branch June 17, 2024 15:02
@aclark02-arcus
Copy link
Collaborator

aclark02-arcus commented Jun 17, 2024

@Jeff-Thompson12, no. I mean't adding a new arg, called decision to that function. So it could be used like:

upload_pkg_list(c("Tplyr","dplyr","dbplyr"), decision = c("Medium Risk", "Low Risk", ""))

Just a suggestion... maybe we'd want to use a named list instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants