Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse riskmetric dependency assessment #806

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

Closes #805

@jthompson-arcus jthompson-arcus marked this pull request as ready for review July 9, 2024 17:33
@jthompson-arcus
Copy link
Collaborator Author

The change in metric calculation is more inline with how the score is being calculated as well with using NROW().

@aclark02-arcus
Copy link
Collaborator

aclark02-arcus commented Jul 10, 2024

Was this PR supposed to synchronize gower too?

image

image

@jthompson-arcus
Copy link
Collaborator Author

jthompson-arcus commented Jul 10, 2024

Yes, did you re-upload the package? It should be showing 0 dependencies.

You have to re-upload because the value is being written to the database.

@aclark02-arcus
Copy link
Collaborator

Yes, did you re-upload the package? It should be showing 0 dependencies.

You have to re-upload because the value is being written to the database.

Whoops, nope. For some reason, I was expecting the table to show one dep instead of the other way around (card showing 0 deps). Sorry

Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏼
Looks good to me

@aclark02-arcus aclark02-arcus merged commit 39eed4d into dev Jul 10, 2024
1 check passed
@jthompson-arcus jthompson-arcus deleted the jt-805-zero_dependencies branch July 10, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants