Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circles collision #4256 #4279

Merged
merged 1 commit into from
May 4, 2019
Merged

Fix circles collision #4256 #4279

merged 1 commit into from
May 4, 2019

Conversation

akuskis
Copy link
Contributor

@akuskis akuskis commented Jan 5, 2019

This PR:

  • Fixes a bug

Describe the changes below:

According to the issue #4256 , math of Circle-Circle Collision was updated.

Before:
original_1

After:
fixed_1

Before:
original_2

After:
fixed_2

@samme
Copy link
Contributor

samme commented Jan 22, 2019

@akuskis You're welcome to attack phaserjs/phaser-ce#579 as well. 😃

@akuskis
Copy link
Contributor Author

akuskis commented Jan 25, 2019

@samme
With suggested changes:

  • I can see bug explained in WebGL render in Internet Explorer 11 #579. When balls are grouped and 'physics.collide' is called on that group from 'update' function.
  • I do not see any issues. When balls are created and collision is set between all of them.

Need to take a look, why behaviour is different, but I think that it's a separate issue.

@photonstorm photonstorm merged commit 63ddc0b into phaserjs:master May 4, 2019
@photonstorm
Copy link
Collaborator

Lovely PR, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akuskis @samme @photonstorm