Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a first run notice detailing the version of amp-devcontainer #688

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jan 9, 2025

🚀 Hey, I have created a Pull Request

Description of changes

This PR adds a first-run-notice file that will be displayed when the container is first started displaying the container version number.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner January 9, 2025 09:28
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Test Results

 2 files  ±0   2 suites  ±0   1m 21s ⏱️ +3s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7b4e6d1. ± Comparison against base commit 7e130ea.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 17 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.57s
✅ GHERKIN gherkin-lint 2 0 0.69s
✅ JSON npm-package-json-lint yes no 0.4s
✅ JSON prettier 15 1 0 0.42s
✅ JSON v8r 14 0 8.72s
✅ MARKDOWN markdownlint 8 0 0 0.79s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.27s
✅ REPOSITORY checkov yes no 14.59s
✅ REPOSITORY gitleaks yes no 0.89s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.27s
✅ REPOSITORY secretlint yes no 0.97s
✅ REPOSITORY syft yes no 1.26s
✅ REPOSITORY trivy yes no 5.06s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 2.68s
✅ SPELL lychee 60 0 1.31s
✅ YAML prettier 22 0 0 0.71s
✅ YAML v8r 22 0 6.29s
✅ YAML yamllint 22 0 0.43s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:9f33ef8b8e572e2f3cbd88b37e61949db4207efa2de3275d2291523d236df2c4

OS/Platform Previous Size Current Size Delta
linux/amd64 482.57M 482.57M 763.00 (+0.00%)
linux/arm64 621.60M 621.60M 767.00 (+0.00%)

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:ae45c1b0e6fb81413cad09399692f08d9690551979eee03a90bca5e5ed9cc535

OS/Platform Previous Size Current Size Delta
linux/amd64 695.53M 695.53M 261.00 (+0.00%)
linux/arm64 677.08M 677.08M 834.00 (+0.00%)

@rjaegers rjaegers marked this pull request as draft January 9, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant