Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reference math round doc en #2040

Merged

Conversation

PhilDaiguille
Copy link
Contributor

This pull request includes updates to the reference/math/functions/round.xml file to enhance the documentation for the round function. The changes focus on updating the parameter types, adding new rounding modes, and providing more detailed examples.

Key changes include:

Documentation Updates:

  • Updated the mode parameter to accept both int and RoundingMode types, with a new default value of RoundingMode::HalfAwayFromZero.
  • Added a note to specify that some newly added rounding modes are only available in the RoundingMode enumeration.
  • Included a new entry in the changelog to document the addition of four new rounding modes in version 8.4.0.

Examples:

  • Added a comprehensive example demonstrating the usage of the RoundingMode enumeration with various rounding modes and their effects on different numbers.

@PhilDaiguille PhilDaiguille force-pushed the feat/update-reference-math-round branch from 5462117 to 2b948b3 Compare February 6, 2025 20:29
@PhilDaiguille PhilDaiguille force-pushed the feat/update-reference-math-round branch from 2b948b3 to c6abc0e Compare February 6, 2025 20:56
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic !

@devnexen devnexen merged commit 4cf175d into php:master Feb 6, 2025
1 check passed
@PhilDaiguille PhilDaiguille deleted the feat/update-reference-math-round branch February 24, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants