Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation of missing reflection class methods #814

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Fan2Shrek
Copy link
Contributor

Here is the translation of the missing ReflectionClass methods

  • ReflectionClass::isEnum()
  • ReflectionClass::isReadOnly()

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits

@Fan2Shrek Fan2Shrek force-pushed the missing-reflection-classe-method branch from 5a3e603 to cb90c6c Compare February 23, 2024 18:19
@Fan2Shrek Fan2Shrek requested a review from Girgias February 23, 2024 18:21
@Fan2Shrek Fan2Shrek force-pushed the missing-reflection-classe-method branch from cb90c6c to e7ac0dc Compare February 23, 2024 18:23
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devnexen devnexen merged commit e8e04df into php:master Feb 23, 2024
1 check passed
@devnexen
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants