Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate date classes #831

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Translate date classes #831

merged 1 commit into from
Mar 7, 2024

Conversation

Fan2Shrek
Copy link
Contributor

Here is the translation of missing date classes:

  • dateError
  • dateException
  • dateInvalidOperationException
  • dateInvalidTimeZoneException
  • dateMalformedIntervalStringException
  • dateMalformedPeriodStringException
  • dateMalformedStringException
  • dateObjectError
  • dateRangeError

@devnexen
Copy link
Member

devnexen commented Mar 4, 2024

Looking good to me.

@devnexen devnexen requested a review from Girgias March 4, 2024 23:01
Girgias
Girgias reviewed Mar 5, 2024
View reviewed changes
Girgias
Girgias approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@Girgias Girgias merged commit b8e2afd into php:master Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fan2Shrek @devnexen @Girgias