Add FQN normalization to constants

php · Jan 5, 2025 · c22feec · c22feec
1 parent d7a81eb
commit c22feec
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/phpdotnet/phd/Package/Generic/XHTML.php b/phpdotnet/phd/Package/Generic/XHTML.php
@@ -1811,7 +1811,7 @@ private function convertConstantNameToId(string $constantName): string {
         $tempLinkValue = str_replace(
             array("\\", "_"),
             array("-", "-"),
-            strtolower(trim($constantName, "_"))
+            trim($this->normalizeFQN($constantName), "_")
         );
 
         if (str_contains($constantName, '::')) {

diff --git a/tests/package/php/constant_links_001.phpt b/tests/package/php/constant_links_001.phpt
@@ -66,6 +66,10 @@ Content:
   <p class="para">
    <strong><code><a href="extensionname2.constantspage2.html#vendor-namespace.constants.definitely-exists2">Vendor\Namespace::DEFINITELY_EXISTS2</a></code></strong>
   </p>
+  <strong><code><a href="extensionname.constantspage.html#constant.extension-namespace-definitely-exists">\Extension\Namespace\DEFINITELY_EXISTS</a></code></strong>
+  <p class="para">
+   <strong><code><a href="extensionname2.constantspage2.html#vendor-namespace.constants.definitely-exists2">\Vendor\Namespace::DEFINITELY_EXISTS2</a></code></strong>
+  </p>
  </div>
 
  <div class="section">

diff --git a/tests/package/php/data/constant_links.xml b/tests/package/php/data/constant_links.xml
@@ -7,6 +7,10 @@
   <para>
    <constant>Vendor\Namespace::DEFINITELY_EXISTS2</constant>
   </para>
+  <constant>\Extension\Namespace\DEFINITELY_EXISTS</constant>
+  <para>
+   <constant>\Vendor\Namespace::DEFINITELY_EXISTS2</constant>
+  </para>
  </section>
 
  <section>