Address review comments

php · Dec 29, 2024 · d35b526 · d35b526
1 parent c225837
commit d35b526
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 2 deletions.
diff --git a/phpdotnet/phd/Package/Generic/XHTML.php b/phpdotnet/phd/Package/Generic/XHTML.php
@@ -1853,8 +1853,8 @@ public function format_property_text($value, $tag) {
         }
 
         $tempLinkValue = str_replace(
-            array("\\", "_", "$"),
-            array("-", "-", ""),
+            ["\\", "_", "$"],
+            ["-", "-", ""],
             strtolower(trim($value, "_"))
         );
 

diff --git a/tests/package/php/data/property_linking.xml b/tests/package/php/data/property_linking.xml
@@ -6,20 +6,29 @@
   <para>
    <property>Vendor\Namespace::$definitely_exists</property>
   </para>
+  <para>
+   <property>Vendor\Namespace::$definitelyExists2</property>
+  </para>
  </section>
 
  <section>
   <para>2. Nonexistent properties</para>
   <para>
    <property>Vendor\Namespace::$this_does_not_exist</property>
   </para>
+  <para>
+   <property>Vendor\Namespace::$thisDoesNotExist2</property>
+  </para>
  </section>
 
  <section>
   <para>3. Properties with leading and trailing underscores in ID</para>
   <para>
    <property>Extension\Class::$__leading_and_trailing_undescores__</property>
   </para>
+  <para>
+   <property>Extension\Class::$__leadingAndTrailingUndescores2__</property>
+  </para>
  </section>
 
 </chapter>
diff --git a/tests/package/php/property_linking.phpt b/tests/package/php/property_linking.phpt
@@ -15,10 +15,18 @@ $indices = [
         "docbook_id" => "vendor-namespace.props.definitely-exists",
         "filename"   => "extensionname.page",
     ],
+    [
+        "docbook_id" => "vendor-namespace.props.definitelyexists2",
+        "filename"   => "extensionname.page",
+    ],
     [
         "docbook_id" => "extension-class.props.leading-and-trailing-undescores",
         "filename"   => "extensionname2.page2",
     ],
+    [
+        "docbook_id" => "extension-class.props.leadingandtrailingundescores2",
+        "filename"   => "extensionname2.page2",
+    ],
 ];
 
 $format = new TestPHPChunkedXHTML($config, $outputHandler);
@@ -53,20 +61,29 @@ Content:
   <p class="para">
    <span class="property"><a href="extensionname.page.html#vendor-namespace.props.definitely-exists">Vendor\Namespace::$definitely_exists</a></span>
   </p>
+  <p class="para">
+   <span class="property"><a href="extensionname.page.html#vendor-namespace.props.definitelyexists2">Vendor\Namespace::$definitelyExists2</a></span>
+  </p>
  </div>
 
  <div class="section">
   <p class="para">%d. Nonexistent properties</p>
   <p class="para">
    <span class="property">Vendor\Namespace::$this_does_not_exist</span>
   </p>
+  <p class="para">
+   <span class="property">Vendor\Namespace::$thisDoesNotExist2</span>
+  </p>
  </div>
 
  <div class="section">
   <p class="para">%d. Properties with leading and trailing underscores in ID</p>
   <p class="para">
    <span class="property"><a href="extensionname2.page2.html#extension-class.props.leading-and-trailing-undescores">Extension\Class::$__leading_and_trailing_undescores__</a></span>
   </p>
+  <p class="para">
+   <span class="property"><a href="extensionname2.page2.html#extension-class.props.leadingandtrailingundescores2">Extension\Class::$__leadingAndTrailingUndescores2__</a></span>
+  </p>
  </div>
 
 </div>