Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full doc-en render test #121

Merged
merged 6 commits into from
Apr 29, 2024
Merged

Full doc-en render test #121

merged 6 commits into from
Apr 29, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Apr 26, 2024

This could be an additional test for testing PhD with a full render of the doc-en repo.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense to me, I don't really know GitHub actions, but this looks ok

runs-on: ubuntu-latest
steps:
- name: Checkout PhD
uses: actions/checkout@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal this uses the V2 version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it should probably be v4. I copied it from an other test. :-)

@haszi
Copy link
Contributor Author

haszi commented Apr 28, 2024

I also renamed the workflow to Render test and the test to just doc-en, and added the output directory to the PhD call.

@haszi haszi requested a review from Girgias April 28, 2024 08:45
@Girgias Girgias merged commit 891340a into php:master Apr 29, 2024
9 checks passed
@haszi haszi deleted the Full-doc-en-render-test branch April 30, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants