Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #91

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Fix tests #91

merged 1 commit into from
Feb 7, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Feb 7, 2024

This PR fixes existing tests with the following changes:

  • refactor existing setup.php to use existing autoloader and initialize basic configuration options
  • add test format from php to xhtml tests
  • use existing TestRender for all tests (as opposed to custom renderer in each one)
  • fix minor format specific issues with dynamic properties and uninitialized arrays
  • update all tests of which the underlying formatting has changed in Phd

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could maybe actually run it in CI now :D

@haszi
Copy link
Contributor Author

haszi commented Feb 7, 2024

I suppose we could maybe actually run it in CI now :D

I actually wanted to ask you about that once this PR was merged. :-)

@Girgias Girgias merged commit e4a363f into php:master Feb 7, 2024
4 checks passed
@haszi haszi deleted the Fix-tests branch February 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants