Implement simplelist attributes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Feb 13, 2024
added 4 commits
February 18, 2024 21:13
Authored-by: Gina Peter Banyard <girgias@php.net>
haszi
force-pushed
the
Implement-simplelist-attributes
branch
from
b2ad566 to
88da6ba
Compare
Girgias
reviewed
Feb 19, 2024
Remove FIXME comment from simpelist entry of element map. Add dedicated method for indentation. Rename simplelist type formatting methods. Move tbody and table tags from tabular formatting method to the main simplelist formatting method.
Girgias
approved these changes
Feb 20, 2024
|
#84 is not needed anymore. :-) I'm not trying to step on your toes though. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
typeandcolumnsattributes of<simplelist>. Preserve backward compatibility by still using<ul>and<li>elements if notypeis specified, ie. by not defaulting tovertas described here. See the included test for examples.Closes #83, supersedes #84 and depends on #95 for proper formatting of whitespace.
Works on the same principle as parameter and return type rendering, ie. storing values, discarding output and processing when the appropriate section is closed.
The main method for processing
<simplelist>is rather big and ugly so I'd appreciate all feedback on how to improve it.