Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on pull requests #99

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Run tests on pull requests #99

merged 2 commits into from
Feb 25, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Feb 16, 2024

Run the few available tests on each push to the repo.

This could be used as a basis for gradually adding tests to at least the format used to generate the official docs (PHP package's XHTML format if I'm not mistaken).

haszi added 2 commits February 16, 2024 16:21
Update test that had an <article> element missing its xml:id which the indexer expects to be present.
@haszi
Copy link
Contributor Author

haszi commented Feb 16, 2024

And there you go, deprecation notices from 8.1 on. :-)

Updated the failing test by adding a xml:id to the <article> element which is expected to be available by the indexer.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually know how GitHub actions works @shivammathur could you have a sanity check look at this?

@Girgias Girgias merged commit 2793dde into php:master Feb 25, 2024
8 checks passed
@haszi haszi deleted the Run-tests branch February 25, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants