moved some table field comments into schema.sql #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This PR moves some comments from schema.sql into the database itself, so that information is present in the running database. * The current is not using foreign key relations, so I added at least the id of the virtual referencing primary key as comment. This way it can be read out by database schema analyzing programs and educate people how these tables fit together. * Changed from DEFAULT '0' to DEFAULT 0 when it is an integer field (cosmetic as mysql handles both) This is just a little step and does not change any field name, although I suggest renaming all fields referencing bugdb.id to 'bugdb_id' (bugdb_votest.bug, bug_subscribe.bug_id, bugdb_comments.bug) for unity.
|
Any thoughts? I would like to see this little cleanup merged before applying changes for #53 voting over ipv6. https://bugs.php.net/bug.php?id=76961 See also |
|
bugs.php.net is no longer really used, and hence, we're sunsetting it. Due to that, I don't think it makes sense to merge this patch, which also has conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves some comments from schema.sql into the database itself, so that information is present in the running database.
The current is not using foreign key relations, so I added at least the id of the virtual referencing primary key as comment. This way it can be read out by database schema analyzing programs and educate people how these tables fit together.
Changed from DEFAULT '0' to DEFAULT 0 when it is an integer field (cosmetic as mysql handles both)
This is just a little step and does not change any field name, although I suggest renaming all fields referencing bugdb.id to 'bugdb_id' (bugdb_votest.bug, bug_subscribe.bug_id, bugdb_comments.bug) for unity.