Skip to content

Regex Domain . can not be edited after Update to v6.0.5 #3308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MrDarth opened this issue Mar 9, 2025 · 7 comments
Open

Regex Domain . can not be edited after Update to v6.0.5 #3308

MrDarth opened this issue Mar 9, 2025 · 7 comments

Comments

@MrDarth
Copy link

MrDarth commented Mar 9, 2025

Versions

Core version is v6.0.5 (Latest: v6.0.5)
Web version is v6.0.2 (Latest: v6.0.2)
FTL version is v6.0.4 (Latest: v6.0.4)

Platform

  • Proxmox LXC with Ubuntu 22.04.5 LTS
  • Platform: Proxmox 8.3.4

Expected behavior

Removing group assignment or enabeld/disable my "block all" regex filter rule.

Actual behavior / bug

After update this morning the status of my block all domain can not be changed. Group assignement is also not changable.
Both actions end with this error:
Invalid request: Specify item in URI {"error":{"key":"uri_error","message":"Invalid request: Specify item in URI","hint":null},"took":0.00011539459228515625}

Image

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to 'Domains'
  2. Change Status from regex filter "." to disabled
  3. or Change group assignment for regex filter "."
@yubiuser
Copy link
Member

yubiuser commented Mar 9, 2025

Can reproduce this. This is a bug

@yubiuser yubiuser transferred this issue from pi-hole/pi-hole Mar 9, 2025
@DL6ER
Copy link
Member

DL6ER commented Mar 9, 2025

Kicking this back into the web repository. As the web interface is indeed not sending the regex, this does not look at all like an FTL problem:

Image

I hope to find some time to check it out later.

@DL6ER DL6ER transferred this issue from pi-hole/FTL Mar 9, 2025
@DL6ER
Copy link
Member

DL6ER commented Mar 9, 2025

I am not exactly sure what is happening here. I added a console.log() immediately before the $.ajax line to print the URL it should use and that seems right, the error message then shows that it did something else (mind the missing .):

Image

I guess the issue here is that "." is interpreted as a dot-sequence in which context it doesn't anything else than an empty string. I still think the browser is actually wrong doing this here as dot-sequences should only be interpreted at the beginning of paths in web URIs (at least if my memory about this is right).

edit Confirmed by trying .. as well which behaves like go-one-directory-up in the browser before being sent to the server.

@DL6ER
Copy link
Member

DL6ER commented Mar 9, 2025

This is a browser-issue and affects specifically these two regular expressions:

  • .
  • ..

Others, like

  • .abc or
  • .*

are working as expected. @MrDarth I'd suggest you use .* as long as we are working on a fix for this. It is basically identical as domain names can never be truly empty.

@MrDarth
Copy link
Author

MrDarth commented Mar 11, 2025

I'd suggest you use .* as long as we are working on a fix for this.

Thanks @DL6ER.
Workaround .* is working fine for my case.

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

@github-actions github-actions bot added the stale label Apr 11, 2025
@yubiuser yubiuser removed the stale label Apr 11, 2025
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants