2FA icon is misaligned

[yubiuser]

When enabling 2FA, the icon in the modal is off

[XhmikosR]

Yeah, that markup is very wrong

Look for other cases with input-group-addon and follow the same markup. Also, drop form-control-feedback doesn't belong to the icon.

[XhmikosR]

I'll take a stab at it after my refactoring patches are upstreamed. We need to clear some fields when the modal closes.

[rdwebdesign]

Looks like this is an issue of CSS order.

I think if we load fontawesome CSS before bootstrap the issue will be fixed.

[XhmikosR]

Or rather we should use the proper Bootstrap 3 markup instead...

[rdwebdesign]

Yeah... my suggestion was made by just looking at the selectors, but looking at the HTML markup, I understand your point.

This markup was created more than 2 years ago (a long time before v6 release) when we were porting the PHP code to Lua. At that time no one payed attention to details and we never tried to fix it.

[XhmikosR]

Yeah, no worries, it's just that there are a few such cases and it just doesn't make sense to not follow the official markup when possible unless we can achieve what we want.

Anyway, this code needs further tweaking later apart from the markup, so that the modal content is cleared when the modal is closed since when it's open we request new data and until the new data comes up, the old is shown.