Skip to content

Commit b37cbc3

Browse files
peternewmanArachnid
authored andcommitted
Try making liquid strict (#232)
* Remove errant .DS_Store file * Ignore .DS_Store * Create a list of organisations * Add an org list * Show number of PIDs per org * Fix HTML issue, sort orgs by title * Try and fix the PID count * Try and fix issues * Try again to fix issues * Try yet again to fix issues * Correct the urlpart * Change to sort_natural, minor code tidy * Try and fix the sorting * Try again to fix the sorting * Remove debugging * Add a link to orgs page * Install dependencies for Travis * Create .travis.yml * Add the Travis script * Update the Ruby version * Bump the Ruby version some more * Switch back to the documented version * Add the exclude * Update based on jekyll/jekyll#5413 * Add github-pages Gem * Add missing gems * Add redcarpet * Switch to tasks so we can run multiple CI tasks * Switch to tasks * Fix the matrix * More matrix fixing * Turn on more htmlproofer options * Make the check less strict * Don't bother complaining about extra jekyll tags * Escape HTML entities * Fix the email link * Fix the link within the 404 page! * Escape more HTML entities * Remove an invalid site URL * Cache ruby bundles * Escape even more HTML entities * Escape yet more HTML entities * Escape more HTML entities and switch to a div * Try and fix the errant paragraph item * Add a Travis badge to the readme * Update Gemfile Adapted from https://github.com/lunaryorn/lunaryorn.github.io * Update _config.yml * Add some more checks to Travis * Report GH Pages versions * Tidy up, add redcarpet back in * Try and stop the spurious paragraph tags * Check Open Graph * Make pid.codes an internal domain * Ensure we've got the fixed html-proofer * Use the original orgpath URL * Ignore some broken URLs * Try and fix the syntax issue * Third try at fixing syntax * Ignore another broken URL * Alternative ignore of a specific URL * Ignore the remaining URLs * Update Instant Infrastructure URL * Remove a redundant URL ignore * Update some broken links * Update links * Remove more resolved links * Force links in kramdown * Format more links for kramdown * Make more links clickable/add more site URLs * Fix more URLs * Fix some more URLs and ignore some others * Fix the remaining broken link * Fix the URL I missed * Make Jekyll liquid processing strict, make general Jekyll processing verbose * Try and fix the Liquid warning * Try and fix more Liquid errors * Fix more Liquid errors * Switch to warn until we've fixed all the errors * Switch back, warn doesn't actually log the errors :( * Fix another error * Revert and try another fix as it just breaks it * Go verbose * Revert and try another fix * Revert and fix * Assign and fix
1 parent d1a7ef4 commit b37cbc3

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

_config.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ share_stumbleupon: false
4747
exclude: [vendor]
4848
gems:
4949
- jekyll-paginate
50+
liquid:
51+
error_mode: strict
52+
verbose: true
5053
markdown: kramdown
5154
kramdown:
5255
auto_ids: true

_includes/data.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
{% assign vids = {{site.pages|where:"layout","vid"|sort:"url"}} %}
2-
{% assign pids = {{site.pages|where:"layout","pid"|sort:"url"}} %}
3-
{% assign orgs = {{site.pages|where:"layout","org"|sort:"url"}} %}
1+
{% assign vids = site.pages|where:"layout","vid"|sort:"url" %}
2+
{% assign pids = site.pages|where:"layout","pid"|sort:"url" %}
3+
{% assign orgs = site.pages|where:"layout","org"|sort:"url" %}

_includes/orgtable.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<thead>
44
<tr><th>Organisation</th><th>Number of PIDs</th></tr>
55
</thead>
6-
{% assign sortedorgs = {{site.pages|where:"layout","org"|sort:"title"}} %}
6+
{% assign sortedorgs = site.pages|where:"layout","org"|sort:"title" %}
77
{% for org in sortedorgs %}
88
{% assign urlparts = org.url|split:"/" %}
99
{% assign owner = urlparts[2] %}

_layouts/pid.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% include data.html %}
22
{% capture orgpath %}/org/{{page.owner}}/{% endcapture %}
3-
{% assign org = {{orgs|where:"url",orgpath|first}} %}
3+
{% assign org = orgs|where:"url",orgpath|first %}
44
{% assign urlparts = page.url|split:"/" %}
55
{% assign vid = urlparts[1] %}
66
{% assign pid = urlparts[2] %}

_layouts/vid.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{% include data.html %}
2-
{% assign org = {{orgs|where:"orgname",page.owner|first}} %}
2+
{% assign org = orgs|where:"orgname",page.owner|first %}
33
{% assign urlparts = page.url|split:"/" %}
44
{% assign vid = urlparts[1] %}
55
<!DOCTYPE html>

0 commit comments

Comments
 (0)