Skip to content

OpenEnergyMonitor request PID 2025 for emon #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

glynhudson
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC licensed Kicad files. What firmware runs on it?

@glynhudson
Copy link
Contributor Author

glynhudson commented Mar 25, 2024

Hi, here's the FW repo: https://github.com/awjlogan/emon32-fw

Is there anything wrong with the Kicad files?

@glynhudson
Copy link
Contributor Author

Can this be merged? Thanks

@tannewt
Copy link
Collaborator

tannewt commented May 21, 2024

Hi, here's the FW repo: https://github.com/awjlogan/emon32-fw

Thanks! Please link to it from the hardware repo. That way folks who follow the link from this repo can find it too. C source and license looks good.

Is there anything wrong with the Kicad files?

Nope. Just a note to myself.

@awjlogan
Copy link

awjlogan commented Jun 4, 2024

Hi @tannewt - thanks for your time on this. I've added a link in the hardware repo to the firmware in commit 888aa99. Let me know if there's anything else that would be useful.

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please switch to a different PID. I merged someone else with the same PID while this was under review. Sorry! I mean to go by first to PR but didn't realize the conflict.

@glynhudson glynhudson changed the title OpenEnergyMonitor request PID 2024 for emon OpenEnergyMonitor request PID 2025 for emon Jun 12, 2024
@glynhudson
Copy link
Contributor Author

@tannewt no worries! I've updated this PR to request PID 2025 instead

@awjlogan
Copy link

Hi @tannewt - apologies for the nudge, but just wanted to check this could be merged? Hoping to get the design out to reviewers soon. Thanks in advance, hope you've had a good weekend :)

Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for switching!

@tannewt tannewt merged commit 41ad08a into pidcodes:master Aug 15, 2024
2 checks passed
@awjlogan
Copy link

Great, thank you @tannewt :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants