Skip to content

Fix error that occurred when the language file content ends with a se… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rblmdst
Copy link
Contributor

@rblmdst rblmdst commented Oct 3, 2018

When the language file content ends with ; (that is a valid JS) for eg:

({
  sum: "The result of the operation {operation} is {result}",
  inbox: "You Have {mails} mensajes",
  hello: "Hi {firstname} {lastname}"
}); // semicolon

Instead of :

({
  sum: "The result of the operation {operation} is {result}",
  inbox: "You Have {mails} mensajes",
  hello: "Hi {firstname} {lastname}"
}) // no semicolon

Then the following error occurred :

  Line 6 > Unreachable ';' after 'return'.
         ...;})();...
  Line 6 > Unnecessary semicolon.
          ...;})();...

Copy link

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me!

@rblmdst
Copy link
Contributor Author

rblmdst commented Jan 8, 2019

Greetings
Any updates about this PR ?

@rblmdst
Copy link
Contributor Author

rblmdst commented Oct 27, 2019

Hello,
This PR has over 1 year now 🤔 !! Is the project not be maintained anymore ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants