Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type of CandidatePairState constants #572

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

stv0g
Copy link
Member

@stv0g stv0g commented May 17, 2023

Fixes #571

@Sean-Der This is another unfortunate instance of an untyped enum. What do you think about fixing this instance as well?

It will break the API, however just like already had to do for the ConnectionState enum.

See also: pion/webrtc#2471 (comment)

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (8680cd5) to head (4acdb2b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #572   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files          42       42           
  Lines        4466     4466           
=======================================
  Hits         3514     3514           
  Misses        734      734           
  Partials      218      218           
Flag Coverage Δ
go 78.68% <ø> (ø)
wasm 23.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der force-pushed the candidate-pair-state-type branch from 5388236 to 4acdb2b Compare March 20, 2024 18:43
@Sean-Der Sean-Der merged commit b386d44 into master Mar 20, 2024
14 checks passed
@Sean-Der Sean-Der deleted the candidate-pair-state-type branch March 20, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Fix type of CandidatePairState enum
2 participants