Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allocate new error inside TaskLoop #714

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Don't allocate new error inside TaskLoop #714

merged 1 commit into from
Jul 25, 2024

Conversation

Sean-Der
Copy link
Member

Libraries use errors.Is to catch this error. Allocating a new one inside internal breaks that

Libraries use errors.Is to catch this error. Allocating a new one inside
internal breaks that
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 22.37%. Comparing base (f15ba98) to head (b7206e2).

Files Patch % Lines
internal/taskloop/taskloop.go 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f15ba98) and HEAD (b7206e2). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f15ba98) HEAD (b7206e2)
go 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #714       +/-   ##
===========================================
- Coverage   79.21%   22.37%   -56.84%     
===========================================
  Files          41       40        -1     
  Lines        3743     3736        -7     
===========================================
- Hits         2965      836     -2129     
- Misses        547     2858     +2311     
+ Partials      231       42      -189     
Flag Coverage Δ
go ?
wasm 22.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit abf50f9 into master Jul 25, 2024
13 of 15 checks passed
@Sean-Der Sean-Der deleted the error-alias branch July 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant