From 37be2f5e001f14cdae7e2e7684e78ac317a0b628 Mon Sep 17 00:00:00 2001
From: Don <100505855+DonFungible@users.noreply.github.com>
Date: Tue, 25 Feb 2025 12:57:42 -0800
Subject: [PATCH] fix displaying rewards

---
 src/app/delegations/[delegatorEvmAddr]/page.tsx |  6 +-----
 src/lib/services/api/delegatorApi.ts            | 11 +++++------
 src/lib/types/delegatorApiTypes.ts              |  2 +-
 3 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/src/app/delegations/[delegatorEvmAddr]/page.tsx b/src/app/delegations/[delegatorEvmAddr]/page.tsx
index c3bba8a..b5189e4 100644
--- a/src/app/delegations/[delegatorEvmAddr]/page.tsx
+++ b/src/app/delegations/[delegatorEvmAddr]/page.tsx
@@ -74,11 +74,7 @@ function OverviewCard({ delegatorAddr }: { delegatorAddr: Address }) {
 
         <DataRow
           title="Total Rewards Earned"
-          value={
-            isRewardsPending || !rewards
-              ? '-'
-              : `${Number(formatEther(rewards.accumulatedRewards, 'gwei')).toFixed(2)} IP`
-          }
+          value={!rewards ? '-' : `${Number(rewards.accumulatedRewards).toFixed(2)} IP`}
           tooltipInfo="The total IP rewards earned from staking on validators"
         />
       </section>
diff --git a/src/lib/services/api/delegatorApi.ts b/src/lib/services/api/delegatorApi.ts
index 016633e..d00fac8 100644
--- a/src/lib/services/api/delegatorApi.ts
+++ b/src/lib/services/api/delegatorApi.ts
@@ -86,18 +86,17 @@ export async function getDelegatorRewards(params: GetDelegatorRewardsParams): Pr
 
   const rewards = response.data.msg
 
-  if (rewards.amount.includes('e')) {
-    const [mantissa, exponent] = rewards.amount.split('e')
-    const exp = parseInt(exponent)
-    const value = parseFloat(mantissa) * Math.pow(10, exp)
+  if (!rewards.amount) {
     return {
-      accumulatedRewards: BigInt(formatEther(BigInt(Math.floor(value)), 'gwei')),
+      accumulatedRewards: '0',
       lastUpdateHeight: rewards.last_update_height,
     }
   }
 
+  const accumulatedRewards = formatEther(BigInt(rewards.amount), 'gwei')
+
   return {
-    accumulatedRewards: BigInt(formatEther(BigInt(rewards.amount), 'gwei')),
+    accumulatedRewards: accumulatedRewards,
     lastUpdateHeight: rewards.last_update_height,
   }
 }
diff --git a/src/lib/types/delegatorApiTypes.ts b/src/lib/types/delegatorApiTypes.ts
index 6c5056c..264bb8a 100644
--- a/src/lib/types/delegatorApiTypes.ts
+++ b/src/lib/types/delegatorApiTypes.ts
@@ -89,7 +89,7 @@ export type GetDelegatorRewardsApiResponse = {
 }
 
 export type GetDelegatorRewardsResponse = {
-  accumulatedRewards: bigint
+  accumulatedRewards: string
   lastUpdateHeight: number
 }