Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin httpx to latest version supporting proxies #10

Closed
wants to merge 1 commit into from
Closed

Pin httpx to latest version supporting proxies #10

wants to merge 1 commit into from

Conversation

MatteoEgmont
Copy link

No description provided.

@MatteoEgmont MatteoEgmont deleted the patch-pin-httpx branch November 29, 2024 08:47
@@ -1,2 +1,3 @@
httpx<0.28
requests>=2.18
openai==1.27.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the fix is to use a later openai version instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry for opening a PR here rather than on my fork, my bad 😅

@platisd
Copy link
Owner

platisd commented Nov 29, 2024

@MatteoEgmont do you think the fact that #11 run successfully means that the fix worked?

@MatteoEgmont
Copy link
Author

@platisd yes, I tested in a repo where we use your action, running with

    steps:
      - uses: platisd/openai-pr-description@175d40a9cfe9c0e9809139ce28f7dc16147a1717

and the execution was successful

@platisd
Copy link
Owner

platisd commented Nov 29, 2024

Nice, will merge then. Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants