[BUG] Large nr of myp errors when upgrading Dash 3.0.2 to Dash 3.0.3 #3277
Comments
|
The typing were not resolved by mypy before because of a decorator on the Some of these look like legitimate typing issues. I'd like to see if possible the type or component and prop name given to some of these errors. The first one is suspicious, but There is a bunch of those with This one seems like mypy auto resolving the list to the items in the initializer. Can manually type it to something like Can we see a snippet for this: |
|
I am seeing the same issue. I've reproduced a minimal example below: Running mypy on this file with dash 3.0.3 installed will give the following error: The order of the str and the H1 doesn't seem to matter, but replacing the str with another H1 does not give an error. EDIT: I can also confirm that running mypy on the same file with dash 3.0.2 installed does not generate any errors. |
|
|
|
@ghaarsma please re-try and let us know - thanks. |
No, it's still a work in progress, there is also a related critical bug with the generation that remove backward compatibility with previous version. |
T4rk1n
added
P1
|
@T4rk1n , Thank you for all your prompt work on this. I will be testing this shortly after it has been released. |
|
I did do a quick test on the new Dash 3.0.4 released (hot off the press). It significantly reduced the amount of mypy errors from ~250 in Dash 3.0.3 to about ~40 for Dash 3.0.4. I did do a quick scan and it looks like the remainder of the mypy errors are self inflicted and I will attempt to clean them up in the next few weeks. Once again, thanks @T4rk1n for all your work |
We are maintaining a decent sized Dash application. We had a relatively smooth 2.18.2 -> 3.0.0 upgrade. But when upgrading from 3.0.2 to 3.0.3 we encountered a very large (~250) number of mypy issues. I could not detect anything in the release notes that would indicate a change in (mypy) typing.
The text was updated successfully, but these errors were encountered: