Added url and image_url for a item #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using CreateOrder we have PurchaseUnitRequest inside it a list of Items, according to paypal docs https://developer.paypal.com/docs/api/orders/v2/#orders_create this item can have a url, and a image_url url: The URL to the item being purchased. Visible to buyer and used in buyer experiences. image_url: The URL of the item's image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added missing fields to a type
Where should the reviewer start?
comparing my change with paypal docs. I already triple checked it but feel free to check it again.
docs: https://developer.paypal.com/docs/api/orders/v2/#orders_create
How should this be manually tested?
By using those fields on a create order request
Any background context you want to provide?
When using CreateOrder we have PurchaseUnitRequest inside it a list of Items, according to paypal docs
this item can have a url, and a image_url
url:
The URL to the item being purchased. Visible to buyer and used in buyer experiences.
image_url:
The URL of the item's image.