Fix PHPStan

pmmp · Feb 15, 2025 · eb3ba86 · eb3ba86
1 parent 3d2fc31
commit eb3ba86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/src/inventory/data/CreativeGroup.php b/src/inventory/data/CreativeGroup.php
@@ -32,27 +32,15 @@ final class CreativeGroup{
 	public readonly Translatable|string $name;
 	public readonly ?Item $icon;
 
-	private function __construct(){
+	private function __construct(CreativeCategory $categoryId, Translatable|string $name, ?Item $icon){
 		//NOOP
 	}
 
 	public static function anonymous(CreativeCategory $categoryId) : self{
-		$result = new self();
-
-		$result->categoryId = $categoryId;
-		$result->name = "";
-		$result->icon = null;
-
-		return $result;
+		return new self($categoryId, "", null);
 	}
 
-	public static function named(CreativeCategory $categoryId, Translatable|string $name, Item $icon) : self{
-		$result = new self();
-
-		$result->categoryId = $categoryId;
-		$result->name = $name;
-		$result->icon = $icon;
-
-		return $result;
+	public static function named(CreativeCategory $categoryId, Translatable|string $name, ?Item $icon = null) : self{
+		return new self($categoryId, $name, $icon);
 	}
 }
diff --git a/src/network/mcpe/cache/CreativeInventoryCache.php b/src/network/mcpe/cache/CreativeInventoryCache.php
@@ -84,7 +84,7 @@ private function buildCreativeInventoryCache(CreativeInventory $inventory) : Cre
 
 				$groups[] = new CreativeGroupEntry(
 					$categoryId,
-					$group->name instanceof Translatable ? $group->name->getText() : (string) $group->name,
+					$group->name instanceof Translatable ? $group->name->getText() : $group->name,
 					$group->icon === null ? ItemStack::null() : $typeConverter->coreItemStackToNet($group->icon)
 				);
 			}