Add blocks interfaces for commons properties #6639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
requested changes
Feb 23, 2025
|
|
||
| use pocketmine\math\Facing; | ||
|
|
||
| interface SingleFacingInterface{ |
There was a problem hiding this comment.
This should be split into two variants AnyFacing and HorizontalFacing
The value sets for get/set are different so we shouldn't use the same interface
dktapps
added
Category: API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues & PRs
Add #6161
Changes
API changes
Add:
AgeableInterfaceAnalogRedstoneSignalEmitterInterfaceColoredInterfaceCoralTypeInterfaceLightableInterfaceMultiFacingInterfacePillarRotationInterfacePoweredByRedstoneInterfaceSignLikeRotationInterfaceSingleFacingInterfaceWoodTypeInterfaceBehavioural changes
Backwards compatibility
No BC Break
Follow-up
Tests