docs(deploy): flag and setting for legacy #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KSXGitHub
commented
Feb 6, 2025
|
I don't know why CI fails |
zkochan
reviewed
Feb 6, 2025
docs/cli/deploy.md
Outdated
Comment on lines
56
to
61
| ## --legacy | ||
|
|
||
| Force legacy deploy implementation. | ||
|
|
||
| Since pnpm v10, by default, `pnpm deploy` will try creating a dedicated lockfile from a shared lockfile for deployment. The `--legacy` flag disables this behavior. | ||
|
|
There was a problem hiding this comment.
also mention the injected dependencies setting that is required in v10
There was a problem hiding this comment.
c817778 has added mention of this setting.
I added it to near top instead of --legacy because this setting is required by both legacy and the new implementation.
There was a problem hiding this comment.
I don't understand. Isn't legacy the algorithm from pnpm v9, which didn't require injected deps?
KSXGitHub
commented
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.