Skip to content

Commit

Permalink
upload_ecr_image for all lambdas 1
Browse files Browse the repository at this point in the history
  • Loading branch information
voxparcxls committed Oct 8, 2024
1 parent e7a0e42 commit cb34c3b
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cicd-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
env:
POETRY_VERSION: "1.8.2"
PYTHON_VERSION: "3.10"
TERRAFORM_VERSION: "1.3.7"
TERRAFORM_VERSION: "1.5.7"
REGISTRY: ghcr.io
jobs:
build:
Expand Down
15 changes: 7 additions & 8 deletions terraform/lambda_functions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,13 @@ resource null_resource upload_ecr_image {
# This doesn't work in terraform 0.13.x because it tries to resolve the image during the plan phase instead of the
# apply phase. Once IA updates to a newer terraform version, this can be used instead of having every lambda
# function depend on the null_resource.upload_ecr_image resource.
#data aws_ecr_image lambda_image {
# depends_on = [
# null_resource.upload_ecr_image
# ]
# repository_name = aws_ecr_repository.lambda-image-repo.name
# image_tag = local.ecr_image_tag
#
#}
data "aws_ecr_image" "lambda_image" {
depends_on = [
null_resource.upload_ecr_image
]
repository_name = aws_ecr_repository.lambda-image-repo.name
image_tag = local.ecr_image_tag
}

resource "aws_lambda_function" "get_dataset_configuration" {
depends_on = [
Expand Down
4 changes: 2 additions & 2 deletions terraform/state_machine_definition.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@
{
"Variable":"$.payload.harmony_job_status",
"StringMatches":"successful",
"Next":"Copy Harmony Results to S3",
"Next":"Copy Harmony Output to S3",
"Comment":"Job successful"
},
{
Expand All @@ -344,7 +344,7 @@
],
"Default":"Wait 20 Seconds"
},
"Copy Harmony Results to S3":{
"Copy Harmony Output to S3":{
"Type":"Task",
"Resource":"${CopyHarmonyOutputToS3Lambda}",
"Parameters":{
Expand Down

0 comments on commit cb34c3b

Please sign in to comment.