Issues/55 Cache harmony client and don't validate EDL on init #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyproject.toml
# Conflicts: # pyproject.toml
# Conflicts: # pyproject.toml
… global variable and will not validate auth credentials on initialization.
frankinspace
added a commit
that referenced
this pull request
Feb 12, 2025
* Prep 0.2.3 * /version 0.2.3rc1 * Issues/54: Handle `cumulus_meta` properly (#57) * /version 0.3.0a0 * /version 0.3.0a1 * /version 0.3.0a2 * /version 0.3.0a3 * Fixed bug where status was not being reported to Cumulus Dashboard by adding `cumulus_meta` back into the output CMA. --------- Co-authored-by: frankinspace <frankinspace@users.noreply.github.com> * /version 0.2.3rc2 * Issues/55 Cache harmony client and don't validate EDL on init (#56) * /version 0.3.0a0 * /version 0.3.0a1 * /version 0.3.0a2 * /version 0.3.0a3 * made client global * Harmony client changed from per request and instead will be cached as global variable and will not validate auth credentials on initialization. * fix lint --------- Co-authored-by: frankinspace <frankinspace@users.noreply.github.com> * /version 0.2.3rc3 * fix changelog * /version 0.2.3rc4 * Load should validate auth from environ, default to false --------- Co-authored-by: frankinspace <frankinspace@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: Closes #55
Description
Harmony client changed from per request and instead will be cached as global variable and will not validate auth credentials on initialization.
Overview of work done
Moved client to global var and added check that environment has not changed.
Overview of verification done
TBD. Will test RC in services UAT
Overview of integration done
TBD
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request